Issue #101: run bestPractices recipe with build #105
Conversation
| - org.openrewrite.java.recipes.RecipeEqualsAndHashCodeCallSuper | ||
| - org.openrewrite.java.recipes.UseTreeRandomId | ||
| - org.openrewrite.java.recipes.migrate.RemoveTraitsUsageRecipes | ||
| - org.openrewrite.staticanalysis.NeedBraces |
There was a problem hiding this comment.
| - org.openrewrite.staticanalysis.NeedBraces | |
| - org.openrewrite.java.InlineMethodCalls | |
| - org.openrewrite.staticanalysis.NeedBraces |
There was a problem hiding this comment.
This recipe replaces the older RemoveTraitsUsageRecipes, as indicated hre:
| # - org.openrewrite.java.recipes.ExecutionContextParameterName | ||
| - org.openrewrite.java.recipes.IsLiteralNullRecipe | ||
| - org.openrewrite.java.recipes.MissingOptionExample | ||
| - org.openrewrite.java.recipes.NoMutableStaticFieldsInRecipes |
There was a problem hiding this comment.
| - org.openrewrite.java.recipes.NoMutableStaticFieldsInRecipes | |
| - org.openrewrite.java.recipes.ExecutionContextParameterName: | |
| parameterName: executionContext | |
| - org.openrewrite.java.recipes.NoMutableStaticFieldsInRecipes |
There was a problem hiding this comment.
This one was commented out above, but was recently extended to take a configurable variable name in response to the feedback received here:
openrewrite/rewrite-rewrite@c52c549
|
@rdiachenko done. kindly review. |
How fast to execute all recipes from rewrite.yml on localhost? Keeping them in ci instead of the build makes sense if local build takes lots of time (say, minutes). If not, then makes sense to me to remove from ci, since all recipes are run during verify phase and we fail ci when there is non-empty diff from running |
|
|
@rdiachenko done. |
| @Override | ||
| public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) { | ||
| public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, | ||
| ExecutionContext executionContext) { |
There was a problem hiding this comment.
Great to see the addition of parameterName to ExecutionContextParameterName has helped consistency here. 🚀
3 participants
Fixes: #101